Fix session schema in testRenameTableAcrossSchema#11978
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 16, 2022
Merged
Conversation
ebyhr
added
the
no-release-notes
ebyhr
force-pushed
the
ebi/test-table-exists
branch
from
b5ae8e7 to
2ac48e0
Compare
findepi
approved these changes
Apr 15, 2022
Member
There was a problem hiding this comment.
Unrelated (should be separate commit)
Also, while format is better for general string manipulation, direct + concatenation allows IntelliJ to apply syntax highlighting. At least my IntelliJ version does SQL syntax highlihting for the code before the change, and doesn't do after.
So maybe just drop the change?
Member
Author
There was a problem hiding this comment.
I don't have a strong opinion, but I feel 3 concatenation for simple SQL is less readable than format even if the former has syntax highlight. Anyway, reverted to the original style.
"ALTER TABLE " + tableName + " RENAME TO " + schemaName + "." + renamedTable
format("ALTER TABLE %s RENAME TO %s.%s", tableName, schemaName, renamedTable)
The previous logic tried to check the below table: "catalog"."schema"."new_schema.renamed_table" It should be: "catalog"."new_schema"."renamed_table"
ebyhr
force-pushed
the
ebi/test-table-exists
branch
from
2ac48e0 to
7d02885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix session schema in testRenameTableAcrossSchema. The previous logic tried to check the below table:
"catalog"."schema"."new_schema.renamed_table"It should be:
"catalog"."new_schema"."renamed_table"Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.